fix(dialog): incorrect node attachment when mode = "normal"
#3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al"` chore(config-provider): improve globalAttach method to handle string and object types
RSS1102
requested review from
chaishi,
uyarn,
xiaosansiji,
maoyiluo,
liweijie0812 and
LoopZhou
as code owners
|
|
|
/update-snapshot |
|
⏳ 正在运行快照更新。。。 CI: Open |
uyarn
approved these changes
Feb 14, 2025
Merged
16 tasks
uyarn
pushed a commit
that referenced
this pull request
Feb 24, 2025
* fix(dialog): dialog should be in the document flow when `mode = "normal"` chore(config-provider): improve globalAttach method to handle string and object types * chore: update snapshot * chore: update `globalAttach` type * chore: add typeof globalConfigAttach is function * chore: 直接调用 globalConfigAttach 内的 `componentName` --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
uyarn
added a commit
that referenced
this pull request
Feb 24, 2025
* feat(drawer): sizeDraggable支持SizeDragLimit类型 (#3465) * feat(drawer): sizeDraggable支持SizeDragLimit类型 * fix: delete comments * chore: update tdesign-icons-vue to 0.3.3 (#3468) Co-authored-by: tdesign-bot <github-actions[bot]@users.noreply.github.com> * chore(submodule): update _common (#3472) * chore(submodule): update _common (#3476) * chore(submodule): update _common (#3477) * fix(auto-complete): options is an empty array, empty is not effective (#3474) * fix(auto-complete): options is an empty array, empty is not effective * chore: revert code * chore: fix cr * fix(transfer): ensure filterTransferData returns only valid items (#3487) perf(transfer): optimize filterTransferData for better performance * refactor: lodash-es instead of lodash (#3486) * refactor: lodash-es instead of lodash * chore: fix * chore: fix * chore: fix * chore: fix * chore: fix * chore: fix * chore: fix * feat(form): add `status` and `tips` rendering in `form-item` component (#3490) * feat(form): add `status` function * feat(form): add tips rendering in form-item component * fix(dialog): incorrect node attachment when `mode = "normal"` (#3493) * fix(dialog): dialog should be in the document flow when `mode = "normal"` chore(config-provider): improve globalAttach method to handle string and object types * chore: update snapshot * chore: update `globalAttach` type * chore: add typeof globalConfigAttach is function * chore: 直接调用 globalConfigAttach 内的 `componentName` --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix(Menu): fix function usage of menu group title (#3497) * fix(statistic): fix decimalPlaces setting 0 is invalid (#3496) * fix(statistic): fix decimalPlaces setting 0 is invalid * chore: format code * chore: del comment * chore: release 1.11.0 (#3499) * chore: release 1.11.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: release 1.11.0-naruto * chore: release 1.11.0-naruto --------- Co-authored-by: huangchen1031 <[email protected]> Co-authored-by: TDesign bot <[email protected]> Co-authored-by: tdesign-bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: liweijie0812 <[email protected]> Co-authored-by: 阿菜 Cai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(config-provider): improve globalAttach method to handle string and object types
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
当前：当
<t-dialog header="Title" body="Would you like to be my friends？" mode="normal" theme="default" visible />时，会将 dialog 会挂载在body下。预期：应该默认跟随之前的文档结构不变。
📝 更新日志
fix(Dialog): 修复
1.10.8版本后当 mode 为 "normal" 时渲染不符合预期的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单