Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new answer button assets #18

Closed
wants to merge 3 commits into from

Conversation

stefaniamak
Copy link
Contributor

@stefaniamak stefaniamak commented Aug 29, 2020

Description

  • An issue with Answer Image positioning:
    Even if there was no issue in previous tests, this time it seemed that the positioning was off
  • Added two new assets about the answer buttons, one as a default image, and one for when hovering/pushing the button.

Changes

For Issue

I believe the issue was that I set a family with fixed height at the column hosting the answer images, which family was meant to set a fixed size at the answer UIImages. What I did, was to remove the family from the column, and add it via code to each new UIImage added before the answer UIButtons.

For background images

New Assets

  • default one

black

  • hover/push

blackPushed

Results

Because the UIButtons match the width of their column, which matches the width of the wider button (the one with the most text in it), the image seems kind of weird to the buttons with less text.

The solution should be to set at each UIButtons the LayoutInfo of "use-content-width": true, but I am not aware of how to do that via code yet.

Screenshot_4

Screenshot_5

Screenshot_6

How to test

  1. Start a game which contains a Dialogue box
  2. Trigger the dialogue box

If you want to test this with LightAndShadow:

  1. Check fix: image's column height LightAndShadow#156
  2. Talk to the NPC (The Fool) in front of you when you start the game

@stefaniamak
Copy link
Contributor Author

This shall better be a feature for the UIButton 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant