-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add responsive image according to hovered UIButton #53
feat: add responsive image according to hovered UIButton #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After having a closer look at this intended feature I think there are no changes needed in LaSR.
assets/skins/dialogScreen.skin
Outdated
@@ -36,6 +36,9 @@ | |||
}, | |||
"ScrollableArea": { | |||
"background": "" | |||
}, | |||
"UIImage": { | |||
"background": "heartsIcon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should work with a background image for the UIImage
widget here.
Note that the background image is rendered behind the widget itself (i.e., the background). The UIImage
widget would render another image on top if properly configured. I think we should rather set the source for the image to render in the widget correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds logical, yes, having a background image should be the way we go about. I'll proceed on removing this line when I work on this task 👍 (or maybe closing that PR will work as well 🤔)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested this out along with the two other related PRs - seems fine! 👍
Clearly a fair bit of back-and-forth review cycles have happened with a bunch of commits with relatively few changes, so I'm going to opt for squash merging these. Changes seem relatively straight forward and nothing really jumps out at me :-)
Nicely done!
Tasks
Purpose
Set an arrow asset to appear in the appropriate UIImage next to the hoved UIButton.
How to test
note: the extra response and large text at the dialogue box is not committed and is not planned to be
![image](https://user-images.githubusercontent.com/48293545/90340862-a66e6d80-e003-11ea-9703-096ab73dbb79.png)