Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add responsive image according to hovered UIButton #53

Merged
merged 14 commits into from
Aug 17, 2020

Conversation

stefaniamak
Copy link
Contributor

@stefaniamak stefaniamak commented Jul 29, 2020

Tasks

  • set desired max and min size for the column layout holding the UIImages

Purpose

Set an arrow asset to appear in the appropriate UIImage next to the hoved UIButton.

How to test

note: the extra response and large text at the dialogue box is not committed and is not planned to be
image

Copy link
Contributor

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After having a closer look at this intended feature I think there are no changes needed in LaSR.

@@ -36,6 +36,9 @@
},
"ScrollableArea": {
"background": ""
},
"UIImage": {
"background": "heartsIcon"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should work with a background image for the UIImage widget here.

Note that the background image is rendered behind the widget itself (i.e., the background). The UIImage widget would render another image on top if properly configured. I think we should rather set the source for the image to render in the widget correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds logical, yes, having a background image should be the way we go about. I'll proceed on removing this line when I work on this task 👍 (or maybe closing that PR will work as well 🤔)

@stefaniamak stefaniamak marked this pull request as ready for review August 16, 2020 21:42
Copy link
Member

@Cervator Cervator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested this out along with the two other related PRs - seems fine! 👍

Clearly a fair bit of back-and-forth review cycles have happened with a bunch of commits with relatively few changes, so I'm going to opt for squash merging these. Changes seem relatively straight forward and nothing really jumps out at me :-)

Nicely done!

@Cervator Cervator merged commit a1b638c into Terasology:develop Aug 17, 2020
@stefaniamak stefaniamak deleted the dialogue-image-next-to-button branch August 18, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants