Skip to content

Commit

Permalink
fix(pointchart):fixed by setting unique id for each point chart (#256)
Browse files Browse the repository at this point in the history
fixed by setting unique id for each point chart

UIC-2161
  • Loading branch information
jitendra-kumawat authored Oct 24, 2019
1 parent 2854610 commit 0aae0b1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
11 changes: 9 additions & 2 deletions superset/assets/src/visualizations/Chartjs/Chartjs.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const propTypes = {
labelColor :PropTypes.string,
fillColor :PropTypes.string,
annotationLineColor :PropTypes.string,
sliceId: PropTypes.number.isRequired,
};
const defaultProps = {
width: '100%',
Expand All @@ -49,15 +50,20 @@ const propTypes = {
labelColor :'black',
fillColor :'red',
annotationLineColor :'black',
sliceId: undefined
};

class ChartJSVis extends React.PureComponent {
constructor(props) {
super(props);
}

getId(){
return 'chartjs-point-chart-'+this.props.sliceId;
}

renderChart(){
var ctx = document.getElementById('chartjs-line-cvs').getContext('2d');
var ctx = document.getElementById(this.getId()).getContext('2d');
var config = this.createConfig();
// console.log(config);
new Chart(ctx, config);
Expand Down Expand Up @@ -169,9 +175,10 @@ const propTypes = {

render() {
let style = {display: 'block',height:this.props.height,width:this.props.width}
let id = this.getId()
return (
<div style ={style}>
<canvas id="chartjs-line-cvs" className="chartjs-render-monitor"
<canvas id={id} className="chartjs-render-monitor"
style={style}></canvas>
</div>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export default function transformProps(chartProps) {
labelColor :getrgb(formData.colorPicker),
fillColor :getrgb(formData.targetColorPicker),
annotationLineColor :getrgb(formData.fillColorPicker),
sliceId: formData.sliceId,
};
}

0 comments on commit 0aae0b1

Please sign in to comment.