Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[UIC-2161]:fixed issue by setting unique id for each point chart #256

Merged
merged 1 commit into from
Oct 24, 2019
Merged

#[UIC-2161]:fixed issue by setting unique id for each point chart #256

merged 1 commit into from
Oct 24, 2019

Conversation

jitendra-kumawat
Copy link

@jitendra-kumawat jitendra-kumawat commented Oct 24, 2019 •
edited
Loading

CATEGORY

BUG FIX
Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Fixed issue by setting unique id for each point chart

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2019-10-24 at 10 48 34 AM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@jitendra-kumawat
fix(pointchart):fixed by setting unique id for each point chart
d233973 
fixed by setting unique id for each point chart

UIC-2161
ankursinghal2005
ankursinghal2005 approved these changes Oct 24, 2019
View reviewed changes
Copy link

@ankursinghal2005 ankursinghal2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankursinghal2005
Copy link

Look good me from code point of view.. functional @jitendra-kumawat tumne check liya hai hi

@jitendra-kumawat
Copy link
Author

Look good me from code point of view.. functional @jitendra-kumawat tumne check liya hai hi

yes

@jitendra-kumawat jitendra-kumawat merged commit 0aae0b1 into master Oct 24, 2019
@jitendra-kumawat jitendra-kumawat deleted the fix/UIC-2161-multiplepointcharts branch October 24, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankursinghal2005 ankursinghal2005 ankursinghal2005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jitendra-kumawat @ankursinghal2005