#[UIC-1885] User should able to replicate dashboard via a REST Call #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 5, 2019 16:01
UIC-1905 #time 4h API creation and verification
added 2 commits
August 6, 2019 17:07
UIC-1904 #time 30m Knox rule and son encoding handling
UIC-1904 #time 10m remove unneeded API
superset/views/core.py
Outdated
| database_id = create_database(database_name,sqlalchemy_uri,extra,impersonate_user) | ||
|
|
||
| dashboard_title = request.form.get('dashboard_title') | ||
| tablesparam = json.loads(r''+request.form.get('tables')) |
There was a problem hiding this comment.
Please replace tablesparam with tables_param to make it more readable.
| def import_dashboard_json(session, data, import_time=None): | ||
| current_tt = int(time.time()) | ||
| import_time = current_tt if import_time is None else import_time | ||
| dashboard = data['dashboards'][0] |
There was a problem hiding this comment.
is there any key with which we can retrieve the value here or has it to be on 0th index always?
There was a problem hiding this comment.
This is array we can iterate but as mentioned we are only supporting single dashboard at this point of time.
There will more changes than just iteration we need to take care (rest API signature will change). Hence will differ it till a ask come or we hit a persuasive usecase
arpit-agarwal
changed the title
arpit-agarwal
pushed a commit
that referenced
this pull request
Aug 7, 2019
* feat(replicate-dashboard): added code for replicate dashboard * feat(replicate-dashboard): rename and text fix * feat(replicate-dashboard): Knox rule and json encoding handling * feat(replicate-dashboard): remove unneeded API * feat(replicate-dashboard): review comment
arpit-agarwal
pushed a commit
that referenced
this pull request
Aug 7, 2019
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Exposed a
replicate_dashboardendpoint to replicate a dashboard from a given JSON template.REST API Details:
superset/replicate_dashboardnonename of database to be createduri for database connection as per sqlalchemy specadditional configuration to establish connection via sqlalchemy_uriTrue | Falsecase sensitivetitle of dashboard to be createdA map of tableplachoder as key and schema.table_name as valuetemplate json to be importedtoken received from /superset/csrf_token/ endpoint to avoid CSRF attackTemplate JSON: User can create a template json by following steps
datasourcesfrom the JSON. In case you won't remove it will be ignoreddatasource_namewithtableplachoder. Wheretableplachoderis key intablesparameter corresponding todatasourceto be used in this slicePOSTMAN: https://www.getpostman.com/collections/f1e82aece15702b7dc3a
Expectation & Limitations
Feature set
Limitation
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@jitendra-kumawat