Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[UIC-2021]: replicate api enhancements #239

Merged
merged 9 commits into from
Aug 30, 2019
Merged

#[UIC-2021]: replicate api enhancements #239

merged 9 commits into from
Aug 30, 2019

Conversation

jitendra-kumawat
Copy link

@jitendra-kumawat jitendra-kumawat commented Aug 26, 2019 •
edited
Loading

CATEGORY

This pr is feature enhancement of #224 , following enhancements are added in replicate dashboard api

  1. reuse of same connection and table to handle unique constraint exception
  2. make template and csrf_token args are compulsory and make (database_name, sqlalchemy_uri, impersonate_user, extra, dashboard_title, tables) args are optional
  3. tables arg set only if there is change in existing datasource for slice

Assumption:

  1. If template and csrf_token are only args set then it is assumed that connection and tables are already created .it is like import of dashboard
  2. While reusing table and connections , table is re-used as per table name already created in db with linked db connection.

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@jitendra-kumawat
feat(replicate-api): added support to handle optional req params and …
636b2df 
…refactor code

added support to handle optional req params and refactor code

UIC-2037
@jitendra-kumawat
feat(replicate-api): added slug support in url
81fa833 
added slug support in url

UIC-2037
@jitendra-kumawat
feat(replicate-api): added UT
a6bc54f 
added  UT

UIC-2037
@jitendra-kumawat
feat(replicate-api): updated UT
76c7683 
updated  UT

UIC-2037
@jitendra-kumawat
feat(replicate-api): updated user password for UT
d9fecaf 
updated   user password  for UT

UIC-2037
@jitendra-kumawat
feat(replicate-api): updated UT
1e1addf 
updated  UT

UIC-2037
@jitendra-kumawat
feat(replicate-api): updated UT
97e7548 
updated  UT

UIC-2037
@jitendra-kumawat
feat(replicate-api): updated UT
d1b5832 
updated  UT

UIC-2037
@jitendra-kumawat
feat(replicate-api): updated UT
0099e4e 
updated  UT

UIC-2037
@jitendra-kumawat jitendra-kumawat marked this pull request as ready for review August 28, 2019 04:54
bipinsoniguavus
bipinsoniguavus approved these changes Aug 30, 2019
View reviewed changes
Copy link

@bipinsoniguavus bipinsoniguavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jitendra-kumawat jitendra-kumawat merged commit 3680648 into master Aug 30, 2019
@jitendra-kumawat jitendra-kumawat deleted the feat/UIC-2021-replicate-api-enhancements branch August 30, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipinsoniguavus bipinsoniguavus bipinsoniguavus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jitendra-kumawat @bipinsoniguavus