Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PhishTank analyzer #127

Closed
wants to merge 7 commits into from
Closed

Fix PhishTank analyzer #127

wants to merge 7 commits into from

Conversation

ilyaglow
Copy link
Contributor

@ilyaglow ilyaglow commented Nov 1, 2017

  • Replace http scheme with https
  • Remove summary() call

Closes #126

mthlvt and others added 6 commits September 26, 2017 13:38
@saadkadhi saadkadhi self-requested a review November 1, 2017 20:18
@saadkadhi saadkadhi self-assigned this Nov 1, 2017
@saadkadhi saadkadhi added scope:analyzer Issue is analyzer related category:bug Issue is related to a bug labels Nov 1, 2017
@saadkadhi
Copy link
Contributor

@ilyaglow see my comment on Issue #126.

@ilyaglow ilyaglow changed the base branch from master to develop November 1, 2017 20:42
@ilyaglow
Fix PhishTank analyzer
10c4cf5 
* Replace http scheme with https
* Remove summary() call
@ilyaglow
Copy link
Contributor Author

ilyaglow commented Nov 1, 2017

Somehow rebase didn't work as expected, sorry. I'll send another PR.

@ilyaglow ilyaglow closed this Nov 1, 2017
@ilyaglow ilyaglow mentioned this pull request Nov 1, 2017
Merged
@ilyaglow ilyaglow deleted the phishtank-fix branch November 1, 2017 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadkadhi saadkadhi Awaiting requested review from saadkadhi

Assignees

@saadkadhi saadkadhi

Labels
category:bug Issue is related to a bug scope:analyzer Issue is analyzer related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilyaglow @saadkadhi @mthlvt @jeromeleonard