Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PhishTank analyzer #128

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Fix PhishTank analyzer #128

merged 1 commit into from
Nov 1, 2017

Conversation

ilyaglow
Copy link
Contributor

@ilyaglow ilyaglow commented Nov 1, 2017

Follow up on #127. Based on develop branch.

  • Replace http scheme with https due to changes in PhishTank API
  • Fix error in summary() call as @saadkadhi pointed out

Hopefully closes #126

@ilyaglow
Fix PhishTank analyzer
575bc49 
* Replace http scheme with https due to changes in PhishTank API
* Fix error in summary() call as @saadkadhi pointed out
saadkadhi
saadkadhi approved these changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@saadkadhi saadkadhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and validated

@saadkadhi saadkadhi merged commit da56463 into TheHive-Project:develop Nov 1, 2017
@ilyaglow ilyaglow deleted the phishtank-fix-2 branch November 1, 2017 21:53
@saadkadhi saadkadhi mentioned this pull request Nov 3, 2017
Closed
@jeromeleonard jeromeleonard added this to the 1.7.0 milestone Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadkadhi saadkadhi saadkadhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyaglow @saadkadhi @jeromeleonard