Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting on asset upload. #72

Merged
merged 4 commits into from
Oct 30, 2021
Merged

Starting on asset upload. #72

merged 4 commits into from
Oct 30, 2021

Conversation

alexanderson1993
Copy link
Member

Description

Replaced the WebSocket netsend API with HTTP,
since it makes it easier to include the uploaded files
inline.

Todo: Create a utility function for moving files
wherever you want, most likely placing them inside the
assets folder. The good news is that the input function
is able to decide whatever they want to do with the file,
which is nice.

Related Issue

Refs #62

How Has This Been Tested?

Types of changes

  • Docs Change (changes were only made to documentation)
  • Refactor (non-breaking change which improves code)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the built-in project documentation.
  • My change adds dependencies to this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Replaced the WebSocket netsend API with HTTP,
since it makes it easier to include the uploaded files
inline.

Todo: Create a utility function for moving files
wherever you want, most likely placing them inside the
assets folder. The good news is that the input function
is able to decide whatever they want to do with the file,
which is nice.
@alexanderson1993 alexanderson1993 mentioned this pull request Oct 26, 2021
11 tasks
@alexanderson1993 alexanderson1993 mentioned this pull request Oct 30, 2021
11 tasks
@alexanderson1993 alexanderson1993 merged commit f082d47 into develop Oct 30, 2021
@alexanderson1993 alexanderson1993 deleted the upload-netsend branch October 30, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hosting assets by the Thorium Nova server An easy way to reference assets from within plugin files
1 participant