-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins 2 #76
Merged
Merged
Plugins 2 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to have clients request any data using parameters. It's basically a glorified real-time live data REST API over websockets, really. The cool thing about it is that it's implemented with React Suspense so to the developer, it behaves as if you were just calling a function. Closes #59
Replaced the WebSocket netsend API with HTTP, since it makes it easier to include the uploaded files inline. Todo: Create a utility function for moving files wherever you want, most likely placing them inside the assets folder. The good news is that the input function is able to decide whatever they want to do with the file, which is nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More work on Plugins. See the referenced issue for more info.
Do not merge until #71 and #72 are merged.
Related Issue
Refs #57 and #26
Types of changes
change)
Checklist: