change(default): no longer set a default random generator #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2024
Closed
Tieske
changed the title
|
@rfl890 mind giving this another test run on Windows? just to ensure that my updates didn't break anything. |
Caching of globals can improve performance by up to 30%. This caches global functions used in `new()`, which is likely to be heavily called. Globals in `randomseed()` and `seed()` have a negligible impact due to the low frequency of calls to those functions.
Adds a higher-priority random seeding technique if in ngx_lua to ensure unique seeds for all workers. Reorders the documentation to reflect priority for the seeding technique.
rewritten entire logic and skip setting a default. several new rng source implementations included
|
manually merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safer to have the user explicitly pick one. 3 rng sources have been included. Preferred is the LuaSystem one since it is available on Windows and Posix (but not "pure Lua").
Also improves the seeding if using the plain Lua rng. Adds a sha1 calculation to improve using the inputs instead of mathematically adding them (ngx worker id + time for example).
TODO: