Skip to content

Commit

Permalink
[Backport release-2.8] Backport 3002 to release 2.8 (#3018)
Browse files Browse the repository at this point in the history
* [2.8] Dense reader: fix user buffer offset computation for multi-index queries. (#3002)

* Dense reader: fix user buffer offset computation for multi-index queries.

The previous implementation of the dense reader would order the results
in the user buffer by N-dimension range index, for example, if there are
2 ranges set per dimensions, the data would be ordered from N-dimension
range 1 to 4. This implementation is incorrect as it doesn't really
return the data in the expected row/column major.

This change computes the correct offset for the data in the user buffers
and returns the data in true row/column major order.

* Addressing feedback from ihnorton.

* Making sure ranges are sorted.

---
TYPE: IMPROVEMENT
DESC: Dense reader: fix user buffer offset computation for multi-index queries.

(cherry picked from commit 740c589)

* [ci] Pin werkzeug to fix GCS emulator startup

(cherry picked from commit f584fb3)

Co-authored-by: KiterLuc <[email protected]>
  • Loading branch information
ihnorton and KiterLuc authored Mar 30, 2022
1 parent 3df9577 commit c3a3b5e
Show file tree
Hide file tree
Showing 3 changed files with 518 additions and 51 deletions.
Loading

0 comments on commit c3a3b5e

Please sign in to comment.