[Backport release-2.8] Backport 3002 to release 2.8 #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x queries. (#3002) * Dense reader: fix user buffer offset computation for multi-index queries. The previous implementation of the dense reader would order the results in the user buffer by N-dimension range index, for example, if there are 2 ranges set per dimensions, the data would be ordered from N-dimension range 1 to 4. This implementation is incorrect as it doesn't really return the data in the expected row/column major. This change computes the correct offset for the data in the user buffers and returns the data in true row/column major order. * Addressing feedback from ihnorton. * Making sure ranges are sorted. --- TYPE: IMPROVEMENT DESC: Dense reader: fix user buffer offset computation for multi-index queries. (cherry picked from commit 740c589)
(cherry picked from commit f584fb3)
KiterLuc
approved these changes
Mar 29, 2022
Shelnutt2
changed the title
Shelnutt2
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: IMPROVEMENT
DESC: Dense reader: fix user buffer offset computation for multi-index queries.
(cherry picked from commit 740c589)