Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedUnion used only for >= 2 types. EmptyUnion (Typed.empty) removed, generated tests #5457

Merged
merged 5 commits into from
Jan 29, 2024
Merged

TypedUnion used only for >= 2 types. EmptyUnion (Typed.empty) removed, generated tests #5457

merged 5 commits into from
Jan 29, 2024

Conversation

arkadius
Copy link
Member

@arkadius arkadius commented Jan 26, 2024 •
edited
Loading

Describe your changes

Warninig - it shouldn't be merge so far. We should extract a separate TypedEmpty instead of reuse TypedNull for empty.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@arkadius arkadius changed the title TypedUnion used only for >= 2 types, for zero types TypedNull used in… TypedUnion used only for >= 2 types, for zero types TypedNull used instead Jan 26, 2024
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

created: #5458
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@arkadius arkadius force-pushed the empty-typed-union-fix branch from 50ce8e0 to 31037bd Compare January 27, 2024 17:30
@github-actions github-actions bot added the docs label Jan 27, 2024
@arkadius arkadius changed the title TypedUnion used only for >= 2 types, for zero types TypedNull used instead TypedUnion used only for >= 2 types. EmptyUnion (Typed.empty) removed Jan 27, 2024
@arkadius arkadius force-pushed the empty-typed-union-fix branch 2 times, most recently from fa58238 to ec2e90c Compare January 27, 2024 18:41
@arkadius arkadius changed the base branch from staging to record-comparing-fix January 27, 2024 19:06
@arkadius arkadius force-pushed the empty-typed-union-fix branch from ec2e90c to 6dc66a1 Compare January 28, 2024 00:33
@arkadius arkadius changed the base branch from record-comparing-fix to staging January 28, 2024 12:08
@arkadius arkadius changed the title TypedUnion used only for >= 2 types. EmptyUnion (Typed.empty) removed TypedUnion used only for >= 2 types. EmptyUnion (Typed.empty) removed, generated tests Jan 28, 2024
@arkadius arkadius force-pushed the empty-typed-union-fix branch from 9d79ec5 to cf1b4e6 Compare January 28, 2024 13:27
@arkadius arkadius marked this pull request as ready for review January 28, 2024 13:30
@arkadius arkadius changed the base branch from staging to record-comparing-fix January 28, 2024 13:54
philemone
philemone reviewed Jan 29, 2024
View reviewed changes
Base automatically changed from record-comparing-fix to staging January 29, 2024 12:40
@arkadius arkadius force-pushed the empty-typed-union-fix branch from cf1b4e6 to 3772542 Compare January 29, 2024 12:44
@arkadius arkadius requested a review from philemone January 29, 2024 15:10
philemone
philemone approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@philemone philemone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🥇

@arkadius arkadius merged commit 46c54b4 into staging Jan 29, 2024
17 checks passed
@arkadius arkadius deleted the empty-typed-union-fix branch January 29, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philemone philemone philemone approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkadius @philemone