New Google Sheets connector #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davinov
commented
Sep 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 97.63% 97.72% +0.09%
==========================================
Files 44 43 -1
Lines 2196 2198 +2
==========================================
+ Hits 2144 2148 +4
+ Misses 52 50 -2
Continue to review full report at Codecov.
|
davinov
force-pushed
the
f/bearer-api-replacement
branch
from
4a5e13d to
624bb20
Compare
testinnplayin
approved these changes
Sep 4, 2020
| async with ClientSession(headers=headers) as session: | ||
| return await fetch(url, session) | ||
|
|
||
| def set_secrets(self, secrets: Dict[str, str]): |
There was a problem hiding this comment.
Ah, en local je l'avais changé à Dict[str, Any] mais si mypy ne fait pas ouin ouin on le laisse en tant que tel ?
|
Je l'ai approuvé mais il y a juste un petit print a enlevé avant de merger ce code |
* feat(googlesheets): beginning of replacing Bearer - CONNECTOR_REGISTRY now returns a Google Sheets connector with auth_flow property - new Google Sheets connector (in addition to old) - No tests yet * feat(googlesheets2): added feature flag - added an empty test * feat(googlesheets2): cleaned out connector * feat(googlesheets2): removed feature flag
added test for codecov
added test for codecov fixed test
testinnplayin
force-pushed
the
f/bearer-api-replacement
branch
from
f891fa7 to
f300b3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Contains @testinnplayin's work to create a new Google Sheets connector, that can use provided OAuth2 secrets.
Secrets are to be acquired and stored outside of this project scope, and provided before doing any data request using the
set_secretmethod.Any connector that will need such secrets will be flagged with
authFlow: "oauth2"Checklist