Upgrade toolchains #1191
Upgrade toolchains #1191
Conversation
- Bump flake - Regenerate LRE toolchains - Update native-cli pulumi build - Bump nightly Rust and fix exposed issues - Fix a misplaced aarch64-linux system configuration in flake (typo fix, doesn't add support for any new targets)
aaronmondal
force-pushed
the
bump-toolchains
branch
from
b517d79 to
2f2ec06
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 2 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable (waiting on @adam-singer and @allada)
There was a problem hiding this comment.
Reviewable status: 0 of 3 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable (waiting on @adam-singer, @allada, and @caass)
There was a problem hiding this comment.
Reviewed 20 of 21 files at r1, all commit messages.
Reviewable status: 1 of 3 LGTMs obtained, and 20 of 21 files reviewed, and 1 discussions need to be resolved (waiting on @adam-singer and @caass)
nativelink-scheduler/src/api_worker_scheduler.rs line 471 at r1 (raw file):
for (property, prop_value) in props { c.publish( &format!("{property}_available_properties"),
nit: There'll be a merge conflict here with the metrics refactor PR.
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and 20 of 21 files reviewed
There was a problem hiding this comment.
Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed
- Bump flake - Regenerate LRE toolchains - Update native-cli pulumi build - Bump nightly Rust and fix exposed issues - Fix a misplaced aarch64-linux system configuration in flake (typo fix, doesn't add support for any new targets)
This change is