Migrate to callPackage syntax #1193
Conversation
- Bump flake - Regenerate LRE toolchains - Update native-cli pulumi build - Bump nightly Rust and fix exposed issues - Fix a misplaced aarch64-linux system configuration in flake (typo fix, doesn't add support for any new targets)
This somewhat subtle change opens up a lot of flexibility for toolchain (re)configuration. Instead of making packages dependent on `pkgs` we now allow individual overrides for every input. Towards crosscompilation.
There was a problem hiding this comment.
+@allada +@adam-singer +@caass +@zbirenbaum
(ignore the first commit which will be rebased away after #1191)
Reviewable status: 0 of 4 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @adam-singer, @allada, @caass, and @zbirenbaum)
There was a problem hiding this comment.
Reviewed 12 of 12 files at r2, all commit messages.
Reviewable status: 1 of 4 LGTMs obtained, and 12 of 32 files reviewed (waiting on @adam-singer, @caass, and @zbirenbaum)
There was a problem hiding this comment.
Reviewable status: 1 of 2 LGTMs obtained, and 12 of 32 files reviewed (waiting on @zbirenbaum)
There was a problem hiding this comment.
Reviewed 20 of 21 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained, and all files reviewed (waiting on @zbirenbaum)
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed
* Upgrade toolchains - Bump flake - Regenerate LRE toolchains - Update native-cli pulumi build - Bump nightly Rust and fix exposed issues - Fix a misplaced aarch64-linux system configuration in flake (typo fix, doesn't add support for any new targets) * Migrate to callPackage syntax This somewhat subtle change opens up a lot of flexibility for toolchain (re)configuration. Instead of making packages dependent on `pkgs` we now allow individual overrides for every input. Towards crosscompilation.
This somewhat subtle change opens up a lot of flexibility for toolchain
(re)configuration. Instead of making packages dependent on
pkgswe nowallow individual overrides for every input.
Towards crosscompilation.
This change is