Skip to content

Commit

Permalink
adding tensordict dependency in validate_binaries.sh (pytorch#2756)
Browse files Browse the repository at this point in the history
Summary:

# context
* failed to directly install torchrec from nightly build: P1736807637
* the reason is that tensordict is not available from https://download.pytorch.org/whl/nightly/*
* so the tensordict has to be installed separately

# changes
* install current tensordict version in the validate_binaries.sh script

Differential Revision: D69950708
  • Loading branch information
TroyGarden authored and facebook-github-bot committed Feb 20, 2025
1 parent 7420484 commit 794d178
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .github/scripts/validate_binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ conda run -n "${CONDA_ENV}" pip install fbgemm-gpu --index-url "$PYTORCH_URL"
# install requirements from pypi
conda run -n "${CONDA_ENV}" pip install torchmetrics==1.0.3

# install tensordict from pypi
conda run -n "${CONDA_ENV}" pip install tensordict==0.7.1

# install torchrec
conda run -n "${CONDA_ENV}" pip install torchrec --index-url "$PYTORCH_URL"

Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/validate-nightly-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
name: validate-nightly-binaries

on:
schedule:
# At 5:30 pm UTC (7:30 am PDT)
- cron: "30 17 * * *"
# Have the ability to trigger this job manually through the API
workflow_dispatch:

push:
branches:
- main
Expand Down

0 comments on commit 794d178

Please sign in to comment.