Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tensordict dependency in validate_binaries.sh #2756

Closed
wants to merge 1 commit into from

Conversation

TroyGarden
Copy link
Contributor

Summary:

context

  • failed to directly install torchrec from nightly build: P1736807637
  • the reason is that tensordict is not available from https://download.pytorch.org/whl/nightly/*
  • so the tensordict has to be installed separately

changes

  • install current tensordict version in the validate_binaries.sh script

Differential Revision: D69950708

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69950708

TroyGarden added a commit to TroyGarden/torchrec that referenced this pull request Feb 20, 2025
Summary:

# context
* failed to directly install torchrec from nightly build: P1736807637
* the reason is that tensordict is not available from https://download.pytorch.org/whl/nightly/*
* so the tensordict has to be installed separately

# changes
* install current tensordict version in the validate_binaries.sh script

Differential Revision: D69950708
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69950708

TroyGarden added a commit to TroyGarden/torchrec that referenced this pull request Feb 20, 2025
Summary:

# context
* failed to directly install torchrec from nightly build: P1736807637
* the reason is that tensordict is not available from https://download.pytorch.org/whl/nightly/*
* so the tensordict has to be installed separately

# changes
* install current tensordict version in the validate_binaries.sh script

Differential Revision: D69950708
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69950708

Summary:

# context
* failed to directly install torchrec from nightly build: P1736807637
* the reason is that tensordict is not available from https://download.pytorch.org/whl/nightly/*
* so the tensordict has to be installed separately

# changes
* install current tensordict version in the validate_binaries.sh script

Differential Revision: D69950708
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69950708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants