Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "save" shortcut to settings screens #4414

Closed
2 tasks
novaugust opened this issue Nov 7, 2014 · 4 comments · Fixed by #4438
Closed
2 tasks

Add "save" shortcut to settings screens #4414

novaugust opened this issue Nov 7, 2014 · 4 comments · Fixed by #4438
Labels
affects:admin Anything relating to Ghost Admin good first issue [triage] Start here if you've never contributed before.
Milestone

Comments

@novaugust
Copy link
Contributor

On a post, ctrl/cmd + s saves the post. I don't see any reason why the same shouldn't be the case for the various settings screens!

  • Save settings/user/xx user screen with ctrl/cmd+s
  • Save settings/general screen

See the core/client/utils/editor-shortcuts for an example of how to make an OS specific shortcuts hash, and core/client/routes/posts.js's shortcuts + actions hashes for an example of how this should be implemented in the two settings routes.

@novaugust novaugust added good first issue [triage] Start here if you've never contributed before. affects:admin Anything relating to Ghost Admin labels Nov 7, 2014
@novaugust novaugust added this to the Next Backlog milestone Nov 7, 2014
@naz
Copy link
Contributor

naz commented Nov 8, 2014

Hi, would love to give this one a try.

@novaugust
Copy link
Contributor Author

👍 Go for it @gargol! Get in touch here or on IRC if you have any issues :)

@naz
Copy link
Contributor

naz commented Nov 11, 2014

I broke it down to two separate commits as these are different pages. Is it ok, or should I squash them?

Also had a look at how OS specific shortcuts were done in re/client/utils/editor-shortcuts, but for simplicity sake just left it with regular notation as 'command+s, ctrl+s': 'save'

Let me know if I missed anything.

@novaugust
Copy link
Contributor Author

@gargol the problem with command+s, ctrl+s is that macs have both of those keys. So now there's two ways of saving on a mac, and we can't assign ctrl+s to anything else (or let their browser use it). So, it does indeed need the weirdness :)
And yes, all one commit please! Once you've done that, open the PR and we'll finish the conversation on it :D
Thanks!

naz added a commit to naz/Ghost that referenced this issue Nov 13, 2014
closes TryGhost#4414
- adds `ctrl/cmd+s` shortcuts to `settings/general` screen
- adds `ctrl/cmd+s` shortcuts to `settings/user/xx` screen
- extracts `ctrlOrCmd` variable to separate module for reuse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin good first issue [triage] Start here if you've never contributed before.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants