Adds 'save' shortcut to settings screens #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking good. I've got one request - would you move the two tiny shortcuts creation code into their respective route? The editor route only has its own shortcuts file because it's huge, but for smaller code like that it'll be easier if everything's in one place. |
closes TryGhost#4414 - adds `ctrl/cmd+s` shortcuts to `settings/general` screen - adds `ctrl/cmd+s` shortcuts to `settings/user/xx` screen - extracts `ctrlOrCmd` variable to separate module for reuse
|
Updated with proposed improvements 😏 |
|
👍 |
novaugust
added a commit
that referenced
this pull request
Nov 13, 2014
Adds 'save' shortcut to settings screens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4414
ctrl/cmd+sshortcuts tosettings/generalscreenctrl/cmd+sshortcuts tosettings/user/xxscreenctrlOrCmdvariable to separate module for reuse