Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/max control broken during Zelda merge #5313

Closed
JohnONolan opened this issue May 23, 2015 · 5 comments
Closed

Min/max control broken during Zelda merge #5313

JohnONolan opened this issue May 23, 2015 · 5 comments

Comments

@JohnONolan
Copy link
Member

The min/max control (bottom left corner of nav menu) broke during the Zelda merge, I'm not sure why. This needs to either be fixed or replaced by the Ember version which @acburdine was working on

@acburdine
Copy link
Member

My PR fixes it and works as it should.

@jaswilli
Copy link
Contributor

@john As far as I can see it's working on master. I have caching disabled and just rebuilt all assets so I think it should be ok.

@ErisDS
Copy link
Member

ErisDS commented May 23, 2015

It works intermittently for me in master - it seems to require a refresh to kick in after signin, will look at @acburdine's PR in a sec ;)

@jaswilli
Copy link
Contributor

it seems to require a refresh to kick in after signin

Ah, that makes sense as those elements that are getting event handlers bound to them won't exist when didInsertElement fires and you're not authenticated, and the only time it will re-fire is if the application is reloaded.

@ErisDS ErisDS modified the milestone: Current Backlog May 25, 2015
@jaswilli
Copy link
Contributor

Closed via #5319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants