[Zelda] Bugs, regressions and todos in master

[ErisDS]

Thought I'd open an issue to cover / keep track of all the bits and pieces we know needs doing now that Zelda is merged.

bugs & small issues

• .icon-check and .icon-chevron have gone AWOL
• Fix up sidebar nav Min/max control broken during Zelda merge #5313 / Refactor autonav show/hide in application view #5311
• Private blog form [Zelda] Private blogs login form & settings design #5073
• 404 / error pages are ugly :(
• Publish/Unpublish menu closes before you can choose an item 90% of the time (menu & popover conflict?
• Notifications don't close after 5 seconds anymore (to be fixed in Notifications Refactor #5409)
• Signup/on-boarding password validation requires 8 characters, input says 7.
• Bugs on URL image uploader Bugs on URL image uploader #5433
• Settings routes don't redirect to signin Zelda settings routes don't redirect to signin #5412
• Nav permissions Zelda Nav Permissions #5403
• title overlap on content screen A too long blog title overlap the right content field in the backend #5402
• Vertical scrolling issue on settings screen Vertical scrolling in the backend settings doesn't work anymore #5401
• Permissions for Team area Permissions for Team area #5434
• localstorage / state for navigation To be done in Persist nav menu state between sessions #5440
• spin buttons Implement button:loading style #3928
• Re-add multi-line placeholder Re-add multi-line placeholder for user invite in onboarding flow #5459

major issues

• Notifications refactor Notifications Refactor #5409
• Post/Tag/User auto-complete 'search' bar [Zelda] Post/Tag/User auto-complete 'search' bar #5343
• Inline Validation [Zelda] Inline Validation  #5336
• Re-implement the tag editing component Re-implement the tag editing component #3800
• Roll out inline validation across the app (being done in Notifications Refactor #5409)

user onboarding flow (Epic: #5315)

• API: New 'PUT' version of /authentication/setup/ API: New 'PUT' version of /authentication/setup/ #5342
• User Onboarding - wiring up setup & signup correctly User Onboarding - wiring up setup & signup correctly #5339
• User Onboarding - Upload Profile Image Component User Onboarding - Upload Profile Image Component #5334 - in progress by @acburdine (open PR Add profile image upload component #5355)
• User Onboarding - Flow navigation component User Onboarding - Flow navigation component #5317

If you think you have found an issue we don't know about, drop a comment and it'll get added to the list.

[letsjustfixit]

Just two minor things:

• 1 :IE 11 Forgotten password link is overlapped with an icon while writing (not a problem really just ugly)

• 2: Firefox 38.01 if you try to select a text inside an input field it still has the same style as before, just the cursor disappeares. Not an issue with chrome or ie11.

Tested Ghost version: commit 7190e1d

[letsjustfixit]

Hey I've found another weirdness with ONLY firefox (38): no scrollbars in the settings page.
It's all good with Opera, Chrome, Vivaldi..

[morficus]

regarding the "select text" not not highlighting... it seems like this is the culprit:
background: lighten(var(--blue), 20%); (src)

lighten() is a SCSS function... but Ghost is no longer using SCSS. So the CSS that gets served up to the browser looks like this:
::selection { background: lighten(hsl(90, 80%, 50%), 20%); }
which gets thrown away / ignored because it's not valid CSS

[ErisDS]

Updated the OP here with an overview of outstanding issues & what's in progress, ready for today's meeting (cc @dbalders). One thing I'm not sure about is the current state of the navigation @JohnONolan & @novaugust ?

[ErisDS]

@JohnONolan if all the bugs in the comments here are sorted, then we can probably close this in favour of #5652 and have a separate issue to track adding localstorage tracking of the menu state? All the other items in here have their own issues.