Changed String.proptype.length to Buffer.byteLength(result) #10046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnguneratne
changed the title
|
Hey @dnguneratne thanks for the PR 😄 I don't think these tests were failing before this change - I would imagine the failure is due to incorrect usage of |
|
We have merged in #10055 so the initial issue has been resolved. Thanks for your input @dnguneratne! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10041
I found two places where
String.prototype.lengthis used to calculate Content-Length.The files are,
\current\core\server\api\shared\headers.jsversions\2.3.0\core\server\api\v0.1\index.js.I switched
JSON.stringify(result).lengthtoBuffer.byteLength(result).The test results were the same as before and after the change with 4 failing tests:
