Correct handling of 'Content-Length' header by using Buffer.byteLength #10055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes TryGhost#10041 1. Why is this change neccesary? String.prototype.length returns the number of code units in the string (number of characters) while Buffer.byteLength returns the actual byute length of a string. 2. How does it address the issue? Places that use String.prototype.length to calculate Content-Length were switched to Buffer.byteLength instead.
|
Thanks @da-edra 🎉 |
allouis
added a commit
that referenced
this pull request
Oct 30, 2018
* master: Version bump to 2.4.0 Updated Ghost-Admin to 2.4.0 Handled error from express-session middleware (#10084) Removed user_id constraint when upserting session (#10085) Added Node v10 Support (#10058) Removed logic for migration script (2.0/6-replace-fixture-posts.js) (#10081) Fixed sanitization issue in subscribers Parsed nconf env values (#10077) 🐛 Fixed missing filename when exporting subscribers csv 🐛 Fixed pagination for subscribers 🐛 Fixed cardWidth being lost on 2.0 imports (#10068) Corrected 'Content-Length' header by using Buffer.byteLength (#10055) Fixed mail api usage of the notifcations api Refactored request unit tests to return promises (#10045) Refactored spam prevention tests to use promises (#10036) Enforced unix line endings (#9871)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10041
Why is this change neccesary?
String.prototype.length returns the number of code units in the string (number
of characters) while Buffer.byteLength returns the actual byute length of a
string.
How does it address the issue?
Places that use String.prototype.length to calculate Content-Length
were switched to Buffer.byteLength instead.
npm test)