Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests from core to root #11700

Merged
merged 7 commits into from
Mar 30, 2020
Merged

Move tests from core to root #11700

merged 7 commits into from
Mar 30, 2020

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented Mar 30, 2020

  • move all test files from core/test to test/
  • all code inside of core/ is then application code
  • tests are correctly at the root level
  • consistent with other repos/projects

@ErisDS ErisDS marked this pull request as ready for review March 30, 2020 13:11
@ErisDS ErisDS merged commit 7f1d3eb into TryGhost:master Mar 30, 2020
@ErisDS ErisDS deleted the move-tests branch March 30, 2020 15:26
daniellockyer pushed a commit that referenced this pull request Jul 26, 2022
- move all test files from core/test to test/
- updated all imports and other references
- all code inside of core/ is then application code
- tests are correctly at the root level
- consistent with other repos/projects

Co-authored-by: Kevin Ansfield <[email protected]>
daniellockyer pushed a commit that referenced this pull request Jul 26, 2022
- move all test files from core/test to test/
- updated all imports and other references
- all code inside of core/ is then application code
- tests are correctly at the root level
- consistent with other repos/projects

Co-authored-by: Kevin Ansfield <[email protected]>
daniellockyer pushed a commit that referenced this pull request Jul 26, 2022
- move all test files from core/test to test/
- updated all imports and other references
- all code inside of core/ is then application code
- tests are correctly at the root level
- consistent with other repos/projects

Co-authored-by: Kevin Ansfield <[email protected]>
daniellockyer added a commit that referenced this pull request Jul 26, 2022
* included commits:
  Updated var declarations to const/let and no lists
  Move tests from core to root (#11700)
  Updated to use slugify method from SDK for safe string
  Added Node v10 Support (#10058)
  Dynamic Routing: Added migration for routes.yaml file (#9692)
  Fixed missing Bluebird require in `security/password.js` (#9624)
  🔥  Drop Node v4 Support
  Added unit tests for models.Invite.add
  Added lib.security.password lib
  Moved unique identifier generation to lib/security
  Moved tokens, url safe and safe string utility to lib/security
daniellockyer added a commit that referenced this pull request Jul 26, 2022
* extracted promise lib files and tests from Ghost
* includes commits:
  Updated var declarations to const/let and no lists
  Move tests from core to root (#11700)
  Extended sequence utility
  Moved pipeline/sequence to lib/promise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants