[HOLD] Added Node v10 Support #10058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis passed 🤘🏽 |
|
Will finish up on Monday 👍 I wanted to get an idea of how much work it is to support Node 10 👻 |
no issue Signed-off-by: kirrg001 <[email protected]>
no issue
no issue - mysql 2.15.0 uses a deprecated notation for timers - e.g. timers.unenroll()
no issue - e.g. knex-migrator used mysql 2.15.0
no issue
no issue - Buffer() is deprecated due to security and usability issues. - https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/
|
@allouis We should probably wait if Node releases another official LTS release 👍 This happened last time. |
allouis
added a commit
that referenced
this pull request
Oct 30, 2018
* master: Version bump to 2.4.0 Updated Ghost-Admin to 2.4.0 Handled error from express-session middleware (#10084) Removed user_id constraint when upserting session (#10085) Added Node v10 Support (#10058) Removed logic for migration script (2.0/6-replace-fixture-posts.js) (#10081) Fixed sanitization issue in subscribers Parsed nconf env values (#10077) 🐛 Fixed missing filename when exporting subscribers csv 🐛 Fixed pagination for subscribers 🐛 Fixed cardWidth being lost on 2.0 imports (#10068) Corrected 'Content-Length' header by using Buffer.byteLength (#10055) Fixed mail api usage of the notifcations api Refactored request unit tests to return promises (#10045) Refactored spam prevention tests to use promises (#10036) Enforced unix line endings (#9871)
|
You guys, supporting Node 10 on the first day of its release :-p You rock! |
daniellockyer
pushed a commit
that referenced
this pull request
Jul 26, 2022
* Added Node v10 Support no issue Signed-off-by: kirrg001 <[email protected]> * Bump amperize to version 0.3.8 no issue * Bump mysql to version 2.16.0 no issue - mysql 2.15.0 uses a deprecated notation for timers - e.g. timers.unenroll() * Bump sub dependencies no issue - e.g. knex-migrator used mysql 2.15.0 * Bump dependencies no issue * Replaced `new Buffer` with `Buffer.from` no issue - Buffer() is deprecated due to security and usability issues. - https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/
daniellockyer
added a commit
that referenced
this pull request
Jul 26, 2022
* included commits: Updated var declarations to const/let and no lists Move tests from core to root (#11700) Updated to use slugify method from SDK for safe string Added Node v10 Support (#10058) Dynamic Routing: Added migration for routes.yaml file (#9692) Fixed missing Bluebird require in `security/password.js` (#9624) 🔥 Drop Node v4 Support Added unit tests for models.Invite.add Added lib.security.password lib Moved unique identifier generation to lib/security Moved tokens, url safe and safe string utility to lib/security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active LTS starts on the 30th of Oct (https://github.com/nodejs/Release).