Refactor autonav show/hide in application view #5311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {{#unless signedOut}} | ||
| {{partial "nav-menu"}} | ||
| {{/unless}} | ||
| {{#if session.isAuthenticated}} |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
acburdine
changed the title
25 tasks
|
This PR appears really broken to me :( I checked twice :( |
no issue - converts the nav-menu from a partial to its own view - converts (most) of the jQuery events to ember actions
|
@ErisDS Fixed it. When I fixed jaswilli's request, I changed one word that broke it. |
|
since jaswilli's PR seems to fix this, I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue