Removed left overs from SASS to Myth conversion #5507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --darkgrey: rgb(var(--rgb-darkgrey)); | ||
| --midgrey: rgb(var(--rgb-midgrey)); | ||
| --lightgrey: rgb(var(--rgb-lightgrey)); | ||
| --superlightgrey: rgb(--rgb-superlightgrey); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Right idea, but not quite the right approach. We've replaced lighten() with color(x lightness()) throughout the rest of the codebase, so this should probably follow the same pattern. Definitely don't want to introduce RGB vars (confusing) -- and no need for a variable at all for the "superlightgrey" colour - it's only used once |
|
@JohnONolan thanks for the comment. I'll update the PR later today. |
Refs TryGhost#5314 - replaced SASS's `lighten` with Myth's `color(x lightness())`
|
@JohnONolan I've updated the PR. Somehow I've missed the |
|
👍 / 👎 ? ;) |
JohnONolan
added a commit
that referenced
this pull request
Jul 6, 2015
Removed left overs from SASS to Myth conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As fixer mentioned on Slack (also was mentioned in a comment), for some reason Firefox didn't show styles for
::-moz-selection. I've checked the code and it turned out that during SASS to Myth conversion (390c017),lightenfunction from SASS has not been removed and browsers were ignoring property for which's value the function was used.Current state of master:
After applied changes: