Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming CanTalk --> cantalk and CanDapter to candapter #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

renaming CanTalk --> cantalk and CanDapter to candapter #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3739c72
rename to lowercase
waldosingleton Nov 21, 2024
aefda38
Rename CanDapter.py to candapter.py
waldosingleton Nov 21, 2024
7ca203f
CanTalk --> cantalk, CanDapter --> candapter
waldosingleton Nov 23, 2024
ab04828
CanTalk --> cantalk
waldosingleton Nov 23, 2024
090c075
Rename CanTalk to cantalk
waldosingleton Nov 23, 2024
6c44d8b
CanTalk --> cantalk
waldosingleton Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 CanTalk/__init__.py → cantalk/__init__.py
View file
Open in desktop
File renamed without changes.
10 changes: 5 additions & 5 deletions CanTalk/CanDapter.py → cantalk/candapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ def get_baud_rate_command(rate: int):
return command


class CanDapter(Node):
class candapter(Node):
def __init__(self):
super().__init__('CanDapter_node')
super().__init__('candapter_node')

self.declare_parameters(
namespace='',
Expand Down Expand Up @@ -102,7 +102,7 @@ def __init__(self):
self.serial_thread.start()

def can_send_callback(self, msg):
if msg.header.frame_id == 'CanDapter_node':
if msg.header.frame_id == 'candapter_node':
return

self.send_command(
Expand Down Expand Up @@ -154,7 +154,7 @@ def can_frame_to_can_stamped(self, frame):
"""

can_stamped = CANStamped()
can_stamped.header.frame_id = 'CanDapter_node'
can_stamped.header.frame_id = 'candapter_node'
can_stamped.header.stamp = self.get_clock().now().to_msg()
can_stamped.can.id = frame[0]
can_stamped.can.data = frame[2]
Expand All @@ -176,7 +176,7 @@ def send_command_with_response(self, command: bytes):

def main(args=None):
rclpy.init(args=args)
node = CanDapter()
node = candapter()
rclpy.spin(node)
node.send_command(b'C')
node.destroy_node()
Expand Down
2 changes: 1 addition & 1 deletion package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>CanTalk</name>
<name>cantalk</name>
<version>0.0.0</version>
<description>TODO: Package description</description>
<maintainer email="[email protected]">chris</maintainer>
Expand Down
Empty file removed resource/CanTalk
View file
Open in desktop
Empty file.
1 change: 1 addition & 0 deletions resource/cantalk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import os
from glob import glob

package_name = 'CanTalk'
package_name = 'cantalk'

setup(
name=package_name,
Expand All @@ -24,7 +24,7 @@
tests_require=['pytest'],
entry_points={
'console_scripts': [
'candapter_node = CanTalk.CanDapter:main'
'candapter_node = cantalk.candapter:main'
],
},
)