Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css update title wrap + links in footer #359

Merged
merged 3 commits into from
Mar 26, 2018

Conversation

lindsayplatt
Copy link

@lindsayplatt lindsayplatt commented Mar 16, 2018

Still noticed some tiny details in how-to-gdp that would be useful for future vizzies.

On mobile, the header words wrapped and disappeared:
image

This fixes that:

image

Desktop remains the same:
image

Also in the footer, the title "Related Visualizations" looked and acted like a link but didn't link to anything, so changed the template. Same for the title of the related vizzie, but I added the URL to that since it should link.

No noticeable appearance, but underlines on hover only work for the ones with links now.
image

@lindsayplatt lindsayplatt requested a review from mwernimont March 16, 2018 13:58
@aappling-usgs
Copy link
Member

@mwernimont could you take a look and merge when ready? it's short.

@mwernimont
Copy link
Contributor

mwernimont commented Mar 22, 2018

I would make the title smaller on mobile over making room for it to wrap.

Simple font-size change when it goes to Desktop to make it bigger, as it will look better if no wrapping occurs

@lindsayplatt
Copy link
Author

Resized font based on screen size.

Desktop:
image

Mobile:
image

@mwernimont did I do that right?

@mwernimont
Copy link
Contributor

I like that more than wrapping!

@mwernimont mwernimont merged commit 04215bc into USGS-VIZLAB:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants