Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sonar production testing builder #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added sonar production testing builder #13

wants to merge 1 commit into from

Conversation

GreTimotej
Copy link

Added builder for sonar production testing https://github.com/UbiquityRobotics/ubiquity_buildbot/blob/feature-sonar-testing/master.cfg#L415
May I merge with master to build an image?

MoffKalast
MoffKalast approved these changes Oct 24, 2022
View reviewed changes
Copy link

@MoffKalast MoffKalast left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well afaik last time I checked buildbot had some problems making images, but if you want to give it a try, go right ahead 👍

I doubt you'll get a review from Rohan in less than a few months, so you might as well merge and try since we can always revert it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoffKalast MoffKalast MoffKalast approved these changes

@rohbotics rohbotics Awaiting requested review from rohbotics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GreTimotej @MoffKalast