Change to same favicon as used in frontend #772
Conversation
johannaengland
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
=======================================
Coverage 78.99% 78.99%
=======================================
Files 74 74
Lines 3637 3637
=======================================
Hits 2873 2873
Misses 764 764 ☔ View full report in Codecov by Sentry. |
| @@ -33,7 +34,7 @@ | |||
| ] | |||
|
|
|||
| urlpatterns = [ | |||
| path("favicon.ico", RedirectView.as_view(url="/static/favicon.ico", permanent=True)), | |||
| path("favicon.ico", RedirectView.as_view(url="/static/favicon.svg", permanent=True)), | |||
There was a problem hiding this comment.
An .ico is not an .svg. I'll check if this works on Monday.
If not, we'll need to make an .ico out of the .svg. I looked at how when working on the index-page PR. Of course there is a zillion ways to do it.
There was a problem hiding this comment.
It works in Firefox for me.
The only browsers that do not support SVGs as favicons are IE and Safari. But since we use it like that in the frontend we can accept that.
|
Update branch via rebase before merge please. |
johannaengland
force-pushed
the
add-favicon-to-index
branch
from
272b5f1 to
66ceb53
Compare
hmpf
force-pushed
the
add-favicon-to-index
branch
from
66ceb53 to
64cc717
Compare
|
Closes #767.