Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to same favicon as used in frontend #772

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Change to same favicon as used in frontend #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed src/argus/site/static/favicon.ico
View file
Open in desktop
Binary file not shown.
75 changes: 75 additions & 0 deletions src/argus/site/static/favicon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion src/argus/site/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
1. Import the include() function: from django.urls import include, path
2. Add a URL to urlpatterns: path('blog/', include('blog.urls'))
"""

from django.contrib import admin
from django.urls import include, path, re_path
from django.views.generic.base import RedirectView
Expand All @@ -33,7 +34,7 @@
]

urlpatterns = [
path("favicon.ico", RedirectView.as_view(url="/static/favicon.ico", permanent=True)),
path("favicon.ico", RedirectView.as_view(url="/static/favicon.svg", permanent=True)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An .ico is not an .svg. I'll check if this works on Monday.

If not, we'll need to make an .ico out of the .svg. I looked at how when working on the index-page PR. Of course there is a zillion ways to do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in Firefox for me.
The only browsers that do not support SVGs as favicons are IE and Safari. But since we use it like that in the frontend we can accept that.

# path(".error/", error), # Only needed when testing error pages and error behavior
path("admin/", admin.site.urls),
path("oidc/", include(psa_urls)),
Expand Down
Loading