New core creation #247
Merged
New core creation #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahahahat
reviewed
Sep 13, 2022
rahahahat
reviewed
Sep 13, 2022
rahahahat
reviewed
Sep 13, 2022
rahahahat
reviewed
Sep 13, 2022
…patible with future configurations
…sociated memory interfaces
jj16791
force-pushed
the
newCoreCreation
branch
from
f890434 to
33c028d
Compare
jj16791
commented
Sep 14, 2022
jj16791
commented
Sep 14, 2022
FinnWilkinson
approved these changes
Sep 15, 2022
rahahahat
reviewed
Sep 15, 2022
…ific alternatives that better reflect their usage
FinnWilkinson
approved these changes
Sep 15, 2022
|
Looks good to me! |
rahahahat
approved these changes
Sep 15, 2022
dANW34V3R
approved these changes
Sep 15, 2022
jj16791
added a commit
that referenced
this pull request
Oct 17, 2022
This PR introduces a new CoreInstance class. The class supports the creation of a SimEng core model, storing all the relevant simulation objects within shared pointers. A key factor in this change being introduced was to improve the ease SimEng's interactions with other frameworks e.g. SST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new CoreInstance class which creates the core and its associated memory interfaces.
main.ccnow creates an instance of this class and uses it to generate the SimEng simulation objects.This change was influenced by the need to remove any dependencies SST had on yaml-cpp due to AppleClang having issues linking them. Through this class, the new SST core wrapper can now use the new CoreINstance class to create all SimEng objects without the need to link against the yaml-ccp external project.