Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS #393

Closed
AScustomWorks opened this issue Mar 29, 2018 · 57 comments
Closed

AS #393

AScustomWorks opened this issue Mar 29, 2018 · 57 comments
Labels

Comments

@AScustomWorks
Copy link
Contributor

Small update to fix some svg file names and custom color for vu meter leds background. Let's see if I got this right:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.0.1",
  "status": "available"
}
@AScustomWorks
Copy link
Contributor Author

Another small update (0.6.0.2), BPM clock code fix, VCA internal name fix:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.0.2",
  "status": "available"
}

@AndrewBelt
Copy link
Member

AndrewBelt commented Mar 30, 2018

Can I use you as a quick test? Since you created this issue, can you close it and reopen it to make sure GitHub lets you do that? Afterwards, I'll close the issue, and then you check if you can reopen it again.

@AScustomWorks
Copy link
Contributor Author

done!

@AndrewBelt
Copy link
Member

Okay, now try to reopen.

@AScustomWorks
Copy link
Contributor Author

The reopen button is gone, can't do it

@AndrewBelt AndrewBelt reopened this Mar 30, 2018
@AScustomWorks
Copy link
Contributor Author

After you reopened, I can see the close and comment button

@AndrewBelt
Copy link
Member

Oh well, I was hoping developers could reopen themselves, but I suppose GitHub disables that for good reason. Since you can comment though, I'll recommend to plugin developers to just make a comment in their closed issue, someone will reopen it, and then someone on the Library Team will handle the request.

@AndrewBelt AndrewBelt mentioned this issue Apr 1, 2018
@mdemanett
Copy link
Contributor

@AndrewBelt this would be good to go for review/build, if x.y.z.w versions will work (0.6.0.2 here)?

@AndrewBelt
Copy link
Member

Yeah, that's fine, although I don't know why plugin developers do it. It could be 0.6.bicycle, as long as it starts with 0.6.

@phdsg
Copy link
Contributor

phdsg commented Apr 3, 2018

updated: 37a08ab

@AndrewBelt
Copy link
Member

AndrewBelt commented Apr 3, 2018

Removed repo submodule because libsamplerate doesn't build on my Mac build system yet. The fix should not use ./configure but instead a custom libsamplerate build someone puts together. The library's really simple and doesn't need its own build system at all. There are just a couple of source changes required to turn it into a directory of .c and .h files that can be adopted into your build system.

@AScustomWorks
Copy link
Contributor Author

AScustomWorks commented Apr 3, 2018

Agree, but I don't have the slightest idea about where/how to make those changes, just followed your example on Fundamental.
Btw. tried with JW's finding, but that still needs the ./configure so not good.

@AScustomWorks
Copy link
Contributor Author

AScustomWorks commented Apr 4, 2018

according to 45f6f7e my makefile should be ok now(made the change the other day, but was not sure about it):

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.0.2",
  "status": "available"
}

@AScustomWorks
Copy link
Contributor Author

Just curious, is there something still wrong? or maybe it just got forgotten?

@AndrewBelt AndrewBelt mentioned this issue Apr 11, 2018
AndrewBelt pushed a commit that referenced this issue Apr 11, 2018
* Reviewed Version Updates: Bogaudio #396, moDllz #389, Valley #407

* added mscHack Repo, Submodule. lotsa code, so maybe someone else could have a 2nd look.

* mscHack version update

* cf: Update repo and manifest

* Reviewed Version Update: Valley

* Bidoo 0.6.1 Manifest & Repo _prereview_

* moDllz: update Repo to 0.6.1

* Revert "moDllz: update Repo to 0.6.1"

This reverts commit 0bd1f40.

* new repo: NonLinearInstruments, pre-review

* manifest update: NonLinearInstruments

* Update NonLinearInstruments.json

* repo update: Ohmer 0.6.2

* Update Ohmer.json

* repo update: FrozenWasteland 0.6.2

* Update FrozenWasteland.json

* repo update: AmalgamatedHarmonics 0.6.1

* manifest update: AmalgamatedHarmonics 0.6.1

* repo update: moDllz (next try)

* repo update: moDllz (caps conflict)

* repo update: AS 0.6.0.2

* manifest update: AS 0.6.0.2

* new manifest: alto777_LFSR

* license typo

* license

* license typo

* license typo

* license typo

* license typo

* one more sneaky one

* test added mscHack repo with --depth=1

* Update and rename KoralfxVCV.json to Koralfx-Modules.json

* repo update: TheXOR 0.6.1

* manifest update: TheXOR 0.6.1

post repo update review

* remove repo: KoralfxVCV (namechange)

* new repo: Koralfx-Modules (former KoralfxVCV)

* Update Koralfx-Modules.json

* repo update: FrozenWasteland 0.6.3

* manifest update: FrozenWasteland 0.6.3

post repo review

* reactivate repo for AS #393

* update repo for AS #393
@AScustomWorks
Copy link
Contributor Author

AScustomWorks commented Apr 12, 2018

Just updated to AS to v0.6.1, with a new module addition and another module update:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.1",
  "status": "available"
}

@AndrewBelt
Copy link
Member

The Review Team still hasn't updated the repo to fix the libsamplerate build.

@phdsg
Copy link
Contributor

phdsg commented Apr 12, 2018

did i not? thought at least the 0.6.0.2 was ready...
@AndrewBelt did it fail during pull or make? or did i miss something?

@AScustomWorks
Copy link
Contributor Author

AScustomWorks commented Apr 14, 2018

Made a small fix to BPM Clock module, latest version is now 0.6.2:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.2",
  "status": "available"
}

@AScustomWorks
Copy link
Contributor Author

One last update before the next PM build I hope, latest version is now 0.6.3:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.3",
  "status": "available"
}

mdemanett added a commit that referenced this issue Apr 16, 2018
@mdemanett
Copy link
Contributor

Updated. Checked the build -- works for me (on mac).

@phdsg
Copy link
Contributor

phdsg commented Apr 18, 2018

@AndrewBelt looks like this wasn't this updated in the last cycle. still something wrong?

@AScustomWorks
Copy link
Contributor Author

Hi, I made another update:
Update to V2.0.3
Removed some leftover extra code on VCA and QUADVCA modules that caused wrong behavior when using the CV Level ports.
Thanks!

@cschol cschol reopened this Apr 9, 2022
@AScustomWorks
Copy link
Contributor Author

Hi again, commented out some code by mistake on the V 2.0.3 update for the VCA and QUADVCA, all fixed now. Please update to V.2.04
Thanks!

@AScustomWorks
Copy link
Contributor Author

Hi!, just a small update with corrected links to the changelog on plugin.json file and graphics license update to CC BY-NC-ND 4.0.
Please update to V2.0.5
Thanks!

@AScustomWorks
Copy link
Contributor Author

Hi again, another small update:
Fixed ReScale input 0/5v to output 0/10v range on setting #4
Fixed link to paid plugins on readme.md

Please update to V2.0.6
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants