Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm useAdaptivityHasHover #6009

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Oct 19, 2023

Описание

Исправляем поведение наведения на элемент

Пример со стилусом и мышкой(до/после):

2023-10-19.15.17.24.mp4

Изменения

Удалил useAdaptivityHasHover, поскольку он только мешает правильной работе

@SevereCloud SevereCloud requested a review from a team as a code owner October 19, 2023 12:17
@github-actions github-actions bot added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Oct 19, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 331.02 KB (-0.04% 🔽)
JS (gzip) 101.17 KB (-0.02% 🔽)
JS (brotli) 83.53 KB (+0.05% 🔺)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 255.93 KB (0%)
CSS (gzip) 33.59 KB (0%)
CSS (brotli) 27.23 KB (0%)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f14670:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 1f14670

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (075ba4c) 79.18% compared to head (1f14670) 79.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6009      +/-   ##
==========================================
- Coverage   79.18%   79.15%   -0.04%     
==========================================
  Files         306      305       -1     
  Lines        9596     9582      -14     
  Branches     3246     3242       -4     
==========================================
- Hits         7599     7585      -14     
  Misses       1997     1997              
Flag Coverage Δ
unittests 79.15% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/vkui/src/components/Tappable/Tappable.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@SevereCloud SevereCloud merged commit eb3b98a into master Oct 19, 2023
@SevereCloud SevereCloud deleted the SevereCloud/fix/rm-useAdaptivityHasHover branch October 19, 2023 14:29
vkcom-publisher pushed a commit that referenced this pull request Oct 19, 2023
vkcom-publisher pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: отсутствует hover эффект при наведении стилусом
3 participants