Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PanelHeaderButton, TabsItem): fix hover effect #6602

Merged
merged 4 commits into from
Feb 28, 2024
Merged

fix(PanelHeaderButton, TabsItem): fix hover effect #6602

merged 4 commits into from
Feb 28, 2024

Conversation

BlackySoul
Copy link
Contributor

Описание

По умолчанию начинаем проставлять hasHover=true, поэтому ловим артефакты из issue #6330

Изменения

"Обнуляем" hover-эффекты на iOS

@BlackySoul BlackySoul requested a review from a team as a code owner February 19, 2024 11:12
@BlackySoul BlackySoul self-assigned this Feb 19, 2024
@github-actions github-actions bot added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Feb 19, 2024
@BlackySoul BlackySoul removed their assignment Feb 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 371.63 KB (+0.01% 🔺)
JS (gzip) 111.99 KB (+0.02% 🔺)
JS (brotli) 90.88 KB (-0.04% 🔽)
JS import Div (tree shaking) 2.74 KB (0%)
CSS 286.13 KB (0%)
CSS (gzip) 36.68 KB (0%)
CSS (brotli) 29.16 KB (0%)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

👀 Docs deployed

Commit aa108e9

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 19, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v5@326a81a). Click here to learn what that means.

Files Patch % Lines
...components/PanelHeaderButton/PanelHeaderButton.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##             v5    #6602   +/-   ##
=====================================
  Coverage      ?   80.75%           
=====================================
  Files         ?      314           
  Lines         ?    10855           
  Branches      ?     3380           
=====================================
  Hits          ?     8766           
  Misses        ?     2089           
  Partials      ?        0
Flag Coverage Δ
unittests 80.75% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew removed the v5 Автоматизация: PR продублируется в ветку v5 label Feb 19, 2024
@BlackySoul @SevereCloud
fix: hover for iPad with mouse
aa108e9 
Co-authored-by: Daniil Suvorov <[email protected]>
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Feb 26, 2024
@inomdzhon inomdzhon removed the v5 Автоматизация: PR продублируется в ветку v5 label Feb 28, 2024
@inomdzhon
Copy link
Contributor

Вижу PR в ветку v5, при этом в issue майлстоун выставлен v6.0.1 🤔

@BlackySoul
Copy link
Contributor Author

Вижу PR в ветку v5, при этом в issue майлстоун выставлен v6.0.1 🤔

Спасибо, что заметил! Изменила, мерджить нужно в v5, в v6 таких проблем нет х)

@BlackySoul BlackySoul merged commit 8fbb6ef into v5 Feb 28, 2024
25 checks passed
@BlackySoul BlackySoul deleted the fix/6330/fix_hover_tappable branch February 28, 2024 11:24
vkcom-publisher pushed a commit that referenced this pull request Feb 28, 2024
@BlackySoul @SevereCloud @actions-user
fix(PanelHeaderButton, TabsItem): fix hover effect (#6602)
d4965a3 
* fix(PanelHeaderButton, TabsItem): fix hover effect

* fix(PanelHeaderButton): fix hover effect

* chore: fix linter error

* fix: hover for iPad with mouse

Co-authored-by: Daniil Suvorov <[email protected]>

---------

Co-authored-by: Daniil Suvorov <[email protected]>
@inomdzhon inomdzhon mentioned this pull request Feb 28, 2024
Closed
@inomdzhon inomdzhon linked an issue Feb 28, 2024 that may be closed by this pull request
[v5][Bug][PanelHeader,Tabbar][iOS]: Изменились hover-эффекты #6330
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevereCloud SevereCloud SevereCloud left review comments

@inomdzhon inomdzhon inomdzhon approved these changes

@mendrew mendrew mendrew approved these changes

Assignees
No one assigned
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v5][Bug][PanelHeader,Tabbar][iOS]: Изменились hover-эффекты
4 participants
@BlackySoul @inomdzhon @mendrew @SevereCloud