fix: enable remapping of numbers #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpoon
force-pushed
the
remapper
branch
2 times, most recently
from
dd05f75 to
13c49b9
Compare
|
Did you experience the crazy slowdown when reproducing the issue before fixing it? |
|
Nope, didn't see any slowdown. This PR should slightly improve perf. Put the remappings into a map so it should be O(1) instead of having to iterate through all the remappings to see if they match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
0to^). Although this PR enables the remapping of ALL numbers, I don't see a real scenario where somebody would want to remap numbers 1-9 as that would override the default count behaviour for motions and operators.afteror acommand)Which issue(s) this PR fixes
#2759
Special notes for your reviewer: