added nowrap option #3192
Closed
added nowrap option #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpoon
requested changes
Nov 5, 2018
src/state/searchState.ts
Outdated
| @@ -223,8 +223,19 @@ export class SearchState { | |||
| } | |||
|
|
|||
| const effectiveDirection = direction * this._searchDirection; | |||
| const forward = effectiveDirection === SearchDirection.Forward; | |||
src/state/searchState.ts
Outdated
| if (!configuration.wrapscan) { | ||
| const last = this._matchRanges.length - 1; | ||
| if ( | ||
| (forward && this._matchRanges[last].contains(startPosition)) || |
There was a problem hiding this comment.
No need to declare last var. I think you can combine it all to 231.
src/state/searchState.ts
Outdated
| (forward && this._matchRanges[last].contains(startPosition)) || | ||
| (!forward && this._matchRanges[0].contains(startPosition)) | ||
| ) { | ||
| return { start: startPosition, end: startPosition, match: false }; |
There was a problem hiding this comment.
match: false
I don't recall the code path, but what is this match used for? Shouldn't it be true?
package.json
Outdated
| }, | ||
| "vim.wrapscan": { | ||
| "type": "boolean", | ||
| "description": "when \"search next\" reaches end of file, it wraps around to the beginning and vice versa", |
There was a problem hiding this comment.
Can we use vim's help text here directly?
http://vimdoc.sourceforge.net/htmldoc/options.html#'wrapscan'.
Searches wrap around the end of the file.
Without it you could bypass it by pressing n on another character than the matchrange.
|
Hey @Rjongenburger, TravisCI finished with status TravisBuddy Request Identifier: ec478e50-e117-11e8-90db-29214a2b47d8 |
This was referenced Aug 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements the wrapscan option.
Which issue(s) this PR fixes
Fixes: #3155