-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nowrapscan
#4028
Implement nowrapscan
#4028
Conversation
Travis tests have failedHey @contrib15, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test
TravisBuddy Request Identifier: 074a3170-cd63-11e9-a9d8-278aeb0f3435 |
Apparently the 5 tests that fail with this PR during CI also failed BEFORE this PR, aka with commit 92c3359. |
@contrib15 Yup, sorry about that - they're fixed. |
Thanks for the fix and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What this PR does / why we need it:
Missing nowrapscan feature
Which issue(s) this PR fixes
#3155
Special notes for your reviewer:
Inspired by aborted PR #3192