Fix escaping in :s substitutions #6891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `parsePattern` generally leaves backslashes alone, passing them on to the regular expression parser. * New `parseReplace` interprets backslashes. New definitions for `\b` (backspace), `\&` (same as `$&`), and `\0` through `\9` (same as `$1` through `$9`). * Rewrite these parsers in imperative style to avoid any stack overflow. Fixes VSCodeVim#6890
|
LGTM, thanks! |
I think the change would be in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix
\escaping in:ssubstitution commands. The pattern and replacement need to be processed differently, because\s need to be preserved in the pattern for passing toRegExp, whereas they need to actually be processed in the replacement.parsePatterngenerally leaves backslashes alone, passing them on to the regular expression parser.parseReplaceinterprets backslashes. New definitions for\b(backspace),\&(same as$&), and\0through\9(same as$1through$9).Which issue(s) this PR fixes
Fixes #6890
Special notes for your reviewer:
I'd like to change how search (
/) works as well, for #6520. But I'm findingsrc/actions/commands/search.tshard to follow. If you could point me in the right direction, I can try to fix that similarly.