Fix /\\c by requiring odd number of \'s before c for case (in)sensitivity #6900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vity Fix VSCodeVim#6520 by requiring an odd number of `\`s before c for the case (in)sensitivity triggers `\c` and `\C`, enabling search for `\c` via `/\\c`. This seems to match how vim works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Require an odd number of
\s before c for the case (in)sensitivity triggers\cand\C, enabling search for\cvia/\\c. This seems to match how vim works.Which issue(s) this PR fixes
Fixes #6520.
Special notes for your reviewer:
searchState.ts. I actually didn't know\cwas a vim feature, which explains why it was just this particular case that was causing problems./[\c]is equivalent to/cin vim, but it still won't work with this patch. This seems less common, and I'm not sure how robustly I could fix it with a pure regular expression, and I don't think we really want to parse the whole regular expression...