Fetching a list of automated emails is missing query params

[ye]

For some reason, Mailchimp API v3 official documentation doesn't mention the usual query params for this particular API endpoint: /automations/{workflow_id}/emails.

So in the corresponding mailchimp3 library call: client.automations.emails.all(workflow_id=''), it accepts neither pagination query params nor field related filters(fields, exclude_fields).

As a result, the results returned from mailchimp are using the default 10 item page. If you have more than 10 automation campaign emails, it will only return the first 10.

I spoke with Mailchimp support, the pagination and field filter query params are global for all the GET calls.

I will try to come up with a PR for this.

[stephenross]

Thank you for the effort, we will look for the PR. Please update the docstrings of any methods that are updated to include queryparams as well as any calls to all and add the appropriate info as shown in the existing functions. When you spoke with support, did they mention updating the documentation to indicate this, or would you be able to ask them to make that update to the documentation?

…

On Jul 13, 2017 3:32 PM, "Ye Wang" ***@***.***> wrote: For some reason, Mailchimp API v3 official documentation doesn't mention the usual query params for this particular API endpoint: /automations/{workflow_id}/emails. So in the corresponding mailchimp3 library call: client.automations.emails.all(workflow_id=''), it accepts neither pagination query params nor field related filters(fields, exclude_fields). As a result, the results returned from mailchimp are using the default 10 item page. If you have more than 10 automation campaign emails, it will only return the first 10. I spoke with Mailchimp support, the pagination and field filter query params are global for all the GET calls. I will try to come up with a PR for this. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#143>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOZHc_sIp4_aPJEhDeR3g-skNuohVmhGks5sNnC9gaJpZM4OXcOk> .

-- Please click to read Notices: http://www.mediweightlossclinics.com/sig/ Confidential Communication http://www.mediweightlossclinics.com/sig/ Educational Purposes Disclaimer http://www.mediweightlossclinics.com/sig/ Franchise Disclosure Statement

[ye]

@stephenross thank you for your quick response and will do as specified! I did request them to update the official documentation and they agreed and promised to relay the feedback to their internal team to fix this. But I have yet to see the changes yet (as of today).

As a proof, this is their response in regard to the fields filter query params being global.

[ye]

@stephenross PR#144 is submitted accordingly above.

Since we are on a time crunch here, I've only implemented for this particular endpoint. I would open a new issue to address the global query params and come up a new PR for that when I get more time to walk though a dozen endpoints and testing them, is that okay? Would love to see this particular endpoint fixed so that our code can work correctly for now first. Thanks.