forked from getporter/porter
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for cli login for storage plugin (getporter#30)
* Add support for cli login for storage plugin Signed-off-by: Simon Davies <[email protected]> * updates from review Signed-off-by: Simon Davies <[email protected]> * missed review comments Signed-off-by: Simon Davies <[email protected]> * fix error message Signed-off-by: Simon Davies <[email protected]> * updated BOM handling Signed-off-by: Simon Davies <[email protected]>
- Loading branch information
1 parent
43ca733
commit 0e8b7e7
Showing
8 changed files
with
374 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| package blob | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "path" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "get.porter.sh/plugin/azure/pkg/azure/azureconfig" | ||
| "github.com/Azure/go-autorest/autorest/azure/cli" | ||
| "github.com/hashicorp/go-hclog" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func Test_GetCredentials(t *testing.T) { | ||
| testcases := []struct { | ||
| name string | ||
| envVarsToSet map[string]string | ||
| config *azureconfig.Config | ||
| wantError string | ||
| }{ | ||
| { | ||
| "Missing Environment Variables", | ||
| map[string]string{}, | ||
| &azureconfig.Config{}, | ||
| "environment variable AZURE_STORAGE_CONNECTION_STRING containing the azure storage connection string was not set:\nazureconfig.Config{EnvConnectionString:\"\", StorageAccount:\"\", StorageAccountResourceGroup:\"\", StorageAccountSubscriptionId:\"\", EnvAzurePrefix:\"\", Vault:\"\"}", | ||
| }, | ||
| { | ||
| "Invalid Connection string", | ||
| map[string]string{ | ||
| "AZURE_STORAGE_CONNECTION_STRING": "Invalid", | ||
| }, | ||
| &azureconfig.Config{}, | ||
| "unexpected format for AZURE_STORAGE_CONNECTION_STRING, could not find AccountName=NAME and AccountKey=KEY in it", | ||
| }, | ||
| { | ||
| "Valid Connection string", | ||
| map[string]string{ | ||
| "AZURE_STORAGE_CONNECTION_STRING": "DefaultEndpointsProtocol=https;AccountName=bmFtZQo=;AccountKey=a2V5Cg==;EndpointSuffix=core.windows.net", | ||
| }, | ||
| &azureconfig.Config{}, | ||
| "", | ||
| }, | ||
| { | ||
| "Missing Storage Acccount Resource Group", | ||
| map[string]string{}, | ||
| &azureconfig.Config{ | ||
| StorageAccount: "account", | ||
| }, | ||
| "resource-group is not set - cannot login with Azure CLI\nazureconfig.Config{EnvConnectionString:\"\", StorageAccount:\"account\", StorageAccountResourceGroup:\"\", StorageAccountSubscriptionId:\"\", EnvAzurePrefix:\"\", Vault:\"\"}", | ||
| }, | ||
| { | ||
| "Missing Storage Acccount Name", | ||
| map[string]string{}, | ||
| &azureconfig.Config{ | ||
| StorageAccountResourceGroup: "group", | ||
| }, | ||
| "account is not set - cannot login with Azure CLI\nazureconfig.Config{EnvConnectionString:\"\", StorageAccount:\"\", StorageAccountResourceGroup:\"group\", StorageAccountSubscriptionId:\"\", EnvAzurePrefix:\"\", Vault:\"\"}", | ||
| }, | ||
| } | ||
| for _, tc := range testcases { | ||
|
|
||
| t.Run(tc.name, func(t *testing.T) { | ||
|
|
||
| logger := hclog.New(&hclog.LoggerOptions{ | ||
| Name: strings.ReplaceAll(tc.name, " ", "_"), | ||
| Output: os.Stderr, | ||
| Level: hclog.Error, | ||
| }) | ||
|
|
||
| for k, v := range tc.envVarsToSet { | ||
| os.Setenv(k, v) | ||
| } | ||
|
|
||
| defer func() { | ||
| for k := range tc.envVarsToSet { | ||
| os.Unsetenv(k) | ||
| } | ||
| }() | ||
|
|
||
| cred, err := GetCredentials(*tc.config, logger) | ||
| if tc.wantError == "" { | ||
| require.NoError(t, err, "GetCredentials should have not returned an error") | ||
| assert.NotNil(t, cred) | ||
| } else { | ||
| require.Error(t, err, "GetCredentials should have returned an error") | ||
| assert.EqualError(t, err, tc.wantError) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func Test_LoginwithCLI(t *testing.T) { | ||
|
|
||
| logger := hclog.New(&hclog.LoggerOptions{ | ||
| Name: t.Name(), | ||
| Output: os.Stderr, | ||
| Level: hclog.Error, | ||
| }) | ||
|
|
||
| config := &azureconfig.Config{ | ||
| StorageAccount: "account", | ||
| StorageAccountResourceGroup: "group", | ||
| } | ||
|
|
||
| _, err := GetCredentials(*config, logger) | ||
| require.Error(t, err, "GetCredentials should have returned an error") | ||
| if isLoggedInWithAzureCLI() { | ||
| assert.Contains(t, err.Error(), "Failed to get storage account keys:") | ||
| } else { | ||
| assert.Contains(t, err.Error(), "Failed to login with Azure CLI:") | ||
| } | ||
| } | ||
| func Test_ParseAzureProfile(t *testing.T) { | ||
|
|
||
| files := []string{"profile_with_bom.json", "profile_without_bom.json"} | ||
| for _, filename := range files { | ||
| testName := fmt.Sprintf("parsing %s", filename) | ||
| t.Run(testName, func(t *testing.T) { | ||
| testdata := path.Join("testdata", filename) | ||
| subscriptionId, err := getCurrentAzureSubscriptionFromProfile(testdata) | ||
| assert.NoError(t, err, "Expected no error parsing Azure Profile") | ||
| assert.Equal(t, "8b5ab980-0253-40d6-b22a-61b3f9d94491", subscriptionId, "Expected Subscription not found parsing Azure Profile") | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func isLoggedInWithAzureCLI() bool { | ||
| _, err := cli.GetTokenFromCLI("https://management.azure.com/") | ||
| return err == nil | ||
| } |
Oops, something went wrong.