porter mixin update command

[jeremyrickard]

Porter should have a way to update mixins that are installed.

See full instructions on what needs to be implemented #30 (comment)

[carolynvs]

This is waiting on #150 to be implemented (installing mixins).

[carolynvs]

The new command should be

porter mixin update NAME [--version|v VERSION]

An alternate form of the command can update all mixins. See #848 for an explanation for how --all should work.

porter mixin update --all

• NAME or --all is required, but both cannot be specified
• --version defaults to latest, and also understands a semver and canary

The following code will need to be modified:

• cmd/porter/mixins - define a new cobra command for the update command
• pkg/porter/mixins.go - define a new function to handle the command
• pkg/mixins/mixin.go - Add an update function to the MixinProvider interface
• pkg/mixins/provider/NEWFILE - implement the functionality
• Link to the new command from the doc nav

See the mixin provider package.

When a mixin is installed, it records where the mixin was installed from in ~/.porter/mixins/cache.json (This is all in pkg/mixins/mixin.go) You should use this file to know the FeedURL or URL to use to find updated binaries for the mixin. If there isn't an entry in the cache for the mixin, try to install it instead using the Install function. If that fails, error out saying you couldn't find the mixin's source, please upgrade using porter mixin install --version.

[carolynvs]

I've updated this issue to include --all from #848

[dev-drprasad]

@carolynvs I think we can close this as it is duplicate of #848 and feature has been implemented

[carolynvs]

#848 was a duplicate of this issue, which is why I closed it. The feature though has not yet been implemented. So if anyone wants to work on it, just leave a comment and give it a go!

[scriptonist]

Hey, @carolynvs I can give it shot!

[carolynvs]

@scriptonist I hope you started without waiting for me to reply. 👍 In case anyone is wondering, please know that it's okay to just leave a comment so that others know that you are working on it but you don't need to wait for me to assign. Thanks for taking it on!

[scriptonist]

Hey @carolynvs thanks! I was feeling a bit under the weather and haven't started working on it, but will find some time to hack on it in the weekend.

[scriptonist]

Hey, @carolynvs did things change a bit after this #30 (comment), did pkg/mixins get renamed to pkg/mixin? Also, should the Update function be part of the PackageManager interface?

[carolynvs]

@scriptonist Ah yes, sorry about that, I did refactor mixins after that comment to account for plugins.

• Yes it is pkg/mixin. I think that was a typo on my part in that original comment. Sorry about that!
• Both mixins and plugins share a common implementation for searching, downloading and installing binaries.

Here is the interface that Porter relies on for both mixins and plugins. So just as you noted, that's where Update should be defined.

https://github.com/deislabs/porter/blob/86cd302984ae01da693f535e7adba85bc02cc323/pkg/pkgmgmt/pkgmgmt.go#L11-L20

The implementation should be in the FileSystem struct.

[carolynvs]

Closing in favor of the mixin design in getporter/proposals#7. Instead of managing a global mixin version, each bundle will specify which mixin and version it uses. There may be a command in porter to bump the version of a mixin used in a bundle, but that will come from the PEP and replace this anyway.