Redundancy stripping #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosumis
reviewed
May 3, 2022
| @@ -245,6 +245,38 @@ private Set<OWLClass> querySubClasses(OWLOntology o, OWLClass e, boolean direct, | |||
|
|
|||
| return subClasses; | |||
| } | |||
|
|
|||
| public Set<OWLClass> querySuperClasses(OWLOntology o, OWLClass e, boolean direct, boolean excludeEquivalentClasses) { | |||
There was a problem hiding this comment.
I'm probably missing something, but aren't these edits to methods that do redundancy stripping on classes, when we need to run it on Individuals? I guess OK if test works...
There was a problem hiding this comment.
Yes, querySuperClasses method is also used by the queryTypes method (line 560) which decides the types of an individual. When direct parameter passed, it filters redundant super classes.
Robbie1977
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation with this issue: VirtualFlyBrain/vfb-pipeline-dumps#27
Named individuals type redundancy stripping added to query based type listing.
Unit tests fixed.