Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundancy stripping broken #27

Closed
dosumis opened this issue Mar 14, 2022 · 3 comments
Closed

Redundancy stripping broken #27

dosumis opened this issue Mar 14, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@dosumis
Copy link
Member

dosumis commented Mar 14, 2022

Reundancy stripping on individuals is broken, e.g. only the middle classification on this individual should be present after redundancy stripping

image

Probably missing robot reduce step in new pipeline.

@dosumis
Copy link
Member Author

dosumis commented Mar 15, 2022

I think this issue can be fixed by removing --named-classes-only true here:
https://github.com/VirtualFlyBrain/vfb-pipeline-dumps/blob/master/dumps.Makefile#L50

We need redundant classification to be stripped from individuals. Presumably this was happening at a later stage in earlier versions of the file. Probably in neo4j loading.

@dosumis dosumis transferred this issue from VirtualFlyBrain/VFB2 Mar 15, 2022
@dosumis dosumis changed the title Redundancy stripping broken + links don't work Redundancy stripping broken Mar 15, 2022
@dosumis
Copy link
Member Author

dosumis commented Mar 15, 2022

Rather than running the whole pipeline, do we have a meaty enough machine to just test run this step?

@dosumis dosumis added the bug Something isn't working label Mar 15, 2022
hkir-dev added a commit that referenced this issue Mar 22, 2022
This was referenced Mar 22, 2022
@Robbie1977
Copy link
Contributor

@hkir-dev the fix you applied doesn't seem to be resolving the example @dosumis raised

After latest load: https://v2a.virtualflybrain.org/org.geppetto.frontend/geppetto?id=VFB_jrchk7jm&i=VFB_00101567,VFB_jrchk7jm

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants