Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(components): update popover polyfill #955

Closed
wants to merge 22 commits into from

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Jan 14, 2023

No description provided.

@yinonov yinonov marked this pull request as ready for review January 15, 2023 07:30
@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #955 (a84061c) into main (d61b119) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a84061c differs from pull request most recent head 352cba0. Consider uploading reports for the commit 352cba0 to get more accurate results

@@            Coverage Diff             @@
##              main      #955    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          123       213    +90     
  Lines         1562      2364   +802     
  Branches       108       132    +24     
==========================================
+ Hits          1562      2364   +802     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/components/src/lib/badge/badge.ts 100.00% <ø> (ø)
libs/components/src/lib/button/button.template.ts 100.00% <ø> (ø)
libs/components/src/lib/fab/fab.template.ts 100.00% <ø> (ø)
libs/components/src/lib/header/header.template.ts 100.00% <ø> (ø)
libs/components/src/lib/layout/layout.ts 100.00% <ø> (ø)
.../src/lib/accordion-item/accordion-item.template.ts 100.00% <100.00%> (ø)
...bs/components/src/lib/accordion-item/definition.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion-item/index.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion/definition.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion/index.ts 100.00% <100.00%> (ø)
... and 168 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rinaok rinaok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinonov The combobox and also the dark mode popup don't work well after this update

@yinonov
Copy link
Contributor Author

yinonov commented Jan 20, 2023

@yinonov The combobox and also the dark mode popup don't work well after this update

resolved

@rinaok
Copy link
Contributor

rinaok commented Jan 22, 2023

@yinonov The combobox and also the dark mode popup don't work well after this update

resolved

@yinonov The dark-mode toggle not working yet

@yinonov
Copy link
Contributor Author

yinonov commented Jan 22, 2023

@yinonov The combobox and also the dark mode popup don't work well after this update

resolved

@yinonov The dark-mode toggle not working yet

it does

Screen.Recording.2023-01-22.at.20.34.59.mov

rinaok
rinaok previously approved these changes Jan 23, 2023
@rinaok rinaok dismissed their stale review January 29, 2023 09:50

light dismiss not working

@rinaok
Copy link
Contributor

rinaok commented Jan 29, 2023

@yinonov The combobox and also the dark mode popup don't work well after this update

resolved

@yinonov The dark-mode toggle not working yet

it does

Screen.Recording.2023-01-22.at.20.34.59.mov

In chrome it doesn't work

@yinonov yinonov marked this pull request as draft January 29, 2023 11:47
@yinonov
Copy link
Contributor Author

yinonov commented Jan 29, 2023

@yinonov The combobox and also the dark mode popup don't work well after this update

resolved

@yinonov The dark-mode toggle not working yet

it does
Screen.Recording.2023-01-22.at.20.34.59.mov

In chrome it doesn't work

in the works oddbird/popover-polyfill#70

@acelletti
Copy link
Contributor

Added JIRA ticket: VIV-867 - Investigate Popover polyfill

@acelletti acelletti closed this Mar 22, 2023
@rinaok rinaok deleted the update-popover-polyfill-0.0.5 branch July 10, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants